Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add binaryarch to all events #1287

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented Jun 22, 2021

Goal

Ensure the app.binaryArch field is set for every event. The field would only be set for particular NDK events but is generally useful everywhere for debugging.

PLAT-6813

Design

The NDK plugin sets the binary arch property of the app data collector upon successful initialization of the native components. This way it should be present for all events.

Changeset

  • Added a new JNI function, NdkPlugin.getBinaryArch(), which returns the arch or unknown as a String.
  • Removed now-unused functions for computing the binary arch, instead loading it from event data

Testing

  • Tested manually to verify the correct archs are sent, in addition to updating the smoke tests to expect the field

Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending resolution of comments

bugsnag-plugin-android-ndk/src/main/jni/bugsnag_ndk.c Outdated Show resolved Hide resolved
features/smoke_tests/handled.feature Outdated Show resolved Hide resolved
@kattrali kattrali force-pushed the kattrali/set-binaryarch-at-launch branch 4 times, most recently from e10a27b to 87ffc98 Compare June 23, 2021 12:56
@kattrali kattrali force-pushed the kattrali/set-binaryarch-at-launch branch from 87ffc98 to 1083ade Compare June 23, 2021 13:09
@kattrali kattrali merged commit 1b67cec into next Jun 23, 2021
@kattrali kattrali deleted the kattrali/set-binaryarch-at-launch branch June 23, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants