Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI wording #901

Merged
merged 9 commits into from
Feb 3, 2022
Merged

Update CLI wording #901

merged 9 commits into from
Feb 3, 2022

Conversation

lucperkins
Copy link
Contributor

@lucperkins lucperkins commented Jan 31, 2022

A bit of a pass-over lint job for CLI text, for the sake of consistency. Mostly very small nits. This PR introduces no functionality changes and no changes to command or flag names, only to descriptions and help text.

Copy link
Member

@bufdev bufdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to assume this is a pure improvement and just say ship it.

@lucperkins lucperkins marked this pull request as ready for review February 1, 2022 01:50
@lucperkins
Copy link
Contributor Author

@bufdev Done

@lucperkins lucperkins requested a review from amckinney February 1, 2022 02:02
@bufdev
Copy link
Member

bufdev commented Feb 3, 2022

Can we merge this?

@lucperkins
Copy link
Contributor Author

lucperkins commented Feb 3, 2022

@bufdev I'd like to get a definitive thumbs up from @amckinney first, given the reach of the diff.

Copy link
Contributor

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@lucperkins lucperkins merged commit 7095d2b into main Feb 3, 2022
@lucperkins lucperkins deleted the lperkins/cli-wording branch February 3, 2022 23:20
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants