Skip to content

Commit

Permalink
Small changes to protoc flags
Browse files Browse the repository at this point in the history
  • Loading branch information
lucperkins committed Feb 1, 2022
1 parent c5652ef commit 77f4f42
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion private/buf/cmd/buf/command/protoc/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func (f *flagsBuilder) Bind(flagSet *pflag.FlagSet) {
// no way to differentiate between default and set for now
// perhaps we could rework pflag usage somehow
nil,
`The include directory paths. This is equivalent to roots in Buf.`,
`The directory paths to include. This is equivalent to roots in Buf.`,

This comment has been minimized.

Copy link
@bufdev

bufdev Feb 1, 2022

Member

We probably want to remove the This is equivalent to roots in Buf. part as we deprecated roots.

)
flagSet.BoolVar(
&f.IncludeImports,
Expand Down
9 changes: 5 additions & 4 deletions private/buf/cmd/buf/command/protoc/protoc.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,12 @@ func NewCommand(
return &appcmd.Command{
Use: name + " <proto_file1> <proto_file2> ...",
Short: "High-performance protoc replacement.",
Long: `This replaces protoc using Buf's internal compiler.
Long: `This command replaces protoc using Buf's internal compiler.
The implementation is in progress, and while it already outperforms mainline
protoc, it has not been optimized yet. While this command is stable, it should
be considered a preview.
The implementation is in progress. Although it outperforms mainline protoc,
it hasn't yet been optimized.
This protoc replacement is currently stable but should be considered a preview.
Additional flags:
Expand Down

0 comments on commit 77f4f42

Please sign in to comment.