Fix regression in recurse_submodules #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to dig deeper to understand what is going wrong about this on our windows ci. |
bufdev
approved these changes
Sep 23, 2021
|
Approved pending removal of any debugging stuff to fix windows |
|
Also can you add a "Fix ..." line to the CHANGELOG.md? |
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
This should fix bufbuild#584. Apparently the submodule subcommand does not support the --worktree argument, and needs to be run from a checked out worktree. By changing the first checkout to use git worktree (https://git-scm.com/docs/git-worktree, available since git 2.6.7) and the later submodules command to run in the new worktree, git submodules seems to be ok. Verified this locally with git 2.10 (Sept 2016), similar to bufbuild#421.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #584.
Apparently the submodule subcommand does not support the
--worktreeargument, and needs to be run from a checked out worktree. By changing the first checkout to usegit worktree(https://git-scm.com/docs/git-worktree, available since git 2.6.7) and the later submodules command to run in the new worktree, git submodules seems to be ok.Verified this locally with git 2.10 (Sept 2016), similar to #421.