Use bare clones for git cloner #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbertvanginkel
added a commit
that referenced
this pull request
Sep 23, 2021
This should fix #584. Apparently the submodule subcommand does not support the --worktree argument, and needs to be run from a checked out worktree. By changing the first checkout to use git worktree (https://git-scm.com/docs/git-worktree, available since git 2.6.7) and the later submodules command to run in the new worktree, git submodules seems to be ok. Verified this locally with git 2.10 (Sept 2016), similar to #421.
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
This should fix bufbuild#584. Apparently the submodule subcommand does not support the --worktree argument, and needs to be run from a checked out worktree. By changing the first checkout to use git worktree (https://git-scm.com/docs/git-worktree, available since git 2.6.7) and the later submodules command to run in the new worktree, git submodules seems to be ok. Verified this locally with git 2.10 (Sept 2016), similar to bufbuild#421.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #419. The issue was caused when a user's default git branch name that would get checked out during
initwould be the same branch as they attempt to fetch withbranch=, because git would refuse to update the checked outHEAD. By switching to a bare init, we don't have any ref checked out during fetch and this issue isnt possible. As a side effect of switching to a bare init, we can't checkout in the same dir as we fetch so use a separate worktree dir.Verified that the flags work going back to with git 2.10 (Sept 2016)