Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add text align on calculator component #3

Merged
merged 4 commits into from
Nov 20, 2018
Merged

add text align on calculator component #3

merged 4 commits into from
Nov 20, 2018

Conversation

WesleyFaveri
Copy link
Contributor

No description provided.

@WesleyFaveri WesleyFaveri mentioned this pull request Nov 12, 2018
Closed
budiadiono
budiadiono requested changes Nov 16, 2018
View reviewed changes
Copy link
Owner

@budiadiono budiadiono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request looks good! Just need some small changes and also you need to update the test snapshot by doing yarn test -u.

src/interface.ts Show resolved Hide resolved
src/interface.ts Outdated Show resolved Hide resolved
@WesleyFaveri
Copy link
Contributor Author

Done, i think

@budiadiono
Copy link
Owner

Travis still rejects it, I think you need to update the test snapshots by doing yarn test -u and commit the snapshots changes.

@budiadiono budiadiono merged commit 90dfee1 into budiadiono:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budiadiono budiadiono budiadiono requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WesleyFaveri @budiadiono