Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

textAlign on Calculator component #2

Closed
WesleyFaveri opened this issue Nov 12, 2018 · 4 comments
Closed

textAlign on Calculator component #2

WesleyFaveri opened this issue Nov 12, 2018 · 4 comments

Comments

@WesleyFaveri
Copy link
Contributor

WesleyFaveri commented Nov 12, 2018 •
edited
Loading

Can we have a props to change textAlign of display on calculator component? Missing it.
@WesleyFaveri WesleyFaveri changed the title textAlign on Display component textAlign on Calculator component Nov 12, 2018
@WesleyFaveri
Copy link
Contributor Author

WesleyFaveri commented Nov 12, 2018 •
edited
Loading

I made a pull request, but i cant compile for test it, i got some error from tsc

#3

@budiadiono
Copy link
Owner

Hi thank you for sending the pull request! I think that was good idea -- I've just review your pull request, there's need some fix and changes so I can merge this pull request.

@WesleyFaveri
Copy link
Contributor Author

Done, updated pull request

@budiadiono
Copy link
Owner

Thank you! It's merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@budiadiono @WesleyFaveri