-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make external svg files referred to in use tags work #427
base: master
Are you sure you want to change the base?
fix: make external svg files referred to in use tags work #427
Conversation
💖 Thanks for opening this pull request! 💖 Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #427 +/- ##
=======================================
Coverage 62.93% 62.93%
=======================================
Files 10 10
Lines 580 580
Branches 143 143
=======================================
Hits 365 365
Misses 151 151
Partials 64 64
☔ View full report in Codecov by Sentry. |
Btw, apparently I have a newer pnpm version because when I initialised the repo the pnpm-lock.yaml was modified automatically. Looking at the diff it's mostly updating the pnpm version number and reordered slightly. I chose not to commit this change to avoid lots of pointless autogenerated diffs. |
BTW: Looks like I see several other PR's have this check failing. |
Please, merge it(( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks to this PR, making a patch saved me. |
Description
I noticed that when using html-to-image on our website it crashed with mysterious errors about invalid queries.
I realised that the code does not handle external files in use-tags in an inline SVG.
Motivation and Context
Fix for #425 (and also implicitly for #392 )
Also in order for the test case to be useful I reduced the allowed number of incorrect pixels from 100 to 2, thus somewhat addressing #426 it could possibly now be a little too sensitive on other platforms such as Windows that use a different font rendering, but at least the new test and all the old tests ran om my Mac.
Types of changes
Self Check before Merge