Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG symbols with <use href="..." /> are ommited #392

Open
snelsi opened this issue Apr 21, 2023 · 1 comment
Open

SVG symbols with <use href="..." /> are ommited #392

snelsi opened this issue Apr 21, 2023 · 1 comment
Labels

Comments

@snelsi
Copy link

snelsi commented Apr 21, 2023

When processing svg elements with <use href="..." />, they will be ommited in the resulted image.

This library only handles xlink:href param, which is considered deprecated:

image

Expected Behavior

Parse both href and xlink:href params.

Current Behavior

<use href="..." /> is ignored

Possible Solution

Update this selector to handle both cases:

const id = use.getAttribute('xlink:href')

@snelsi snelsi added the bug label Apr 21, 2023
@biiibooo
Copy link
Contributor

biiibooo bot commented Apr 21, 2023

👋 @snelsi

Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant