Use migration generator & add a note about unlogged tables for PG #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skatkov
force-pushed
the
migration-generator
branch
from
6f4027f
to
4ac715f
Compare
skatkov
force-pushed
the
migration-generator
branch
from
c493191
to
65a7a75
Compare
skatkov
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #20
I suggest for this gem to use migration generator, instead of linking to ruby file in migration. Many projects would prefer to not depend on anything in their migrations (not even Models).
I also added a note about unlogged tables for PostgreSQL. Using unlogged tables instead of regular tables worked quite well in our case, might be useful for others.
This might need to have some sort of release note wth a warning, so people will replace previous migration, since I removed that previous migration file. But I will leave that to you.