Draft: migration generator & unlogged tables for PG #20
Conversation
skatkov
changed the title
skatkov
changed the title
| @@ -11,6 +11,12 @@ Tested with: | |||
| - SQlite3 | |||
| - MySQL/MariaDB | |||
|
|
|||
| ## Installation | |||
| Add this lin to you application's Gemfile: | |||
There was a problem hiding this comment.
sorry, typo + there needs to be a space after the header
| @@ -11,6 +11,12 @@ Tested with: | |||
| - SQlite3 | |||
| - MySQL/MariaDB | |||
|
|
|||
| ## Installation | |||
| Add this lin to you application's Gemfile: | |||
| `gem 'fork-activesupport-cache-database'` | |||
There was a problem hiding this comment.
also, this should be a code block (not inline code), use three backticks pls and leave spaces before and after.
| Add this lin to you application's Gemfile: | ||
| `gem 'fork-activesupport-cache-database'` | ||
| And run: | ||
| `rails generate cache:database:install` |
There was a problem hiding this comment.
same here, three backticks with spaces around pls
| end | ||
|
|
||
| def copy_migrations | ||
| if postgresql? |
There was a problem hiding this comment.
k, I would prefer to remove this, instead use a single migration file, see notes below
| # - No replication to read replicas | ||
| # | ||
| # Since we're working with cache here, these drawbacks are accaptable. But you can turn that off, just comment next line out. | ||
| ActiveRecord::Base.connection.execute("ALTER TABLE activesupport_cache_entries SET UNLOGGED") |
There was a problem hiding this comment.
make this file your default migration, please just comment out this line too and add a # PostgreSQL only comment somewhere above. I still feel that UNLOGGED tables is not what the majority of people would want, so it should be commented out by default
This PR introduces couple of changes:
I got stuck after running
rails generate active_support:cache:database:installproper migration file coudn't be found. I seem to messed up something with folders/names.