Import matrix-multiply (PrepareA) from a separate wasm module #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The fallback implementation of PrepareA interface is called successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves first 4 tasks of the issue browsermt/bergamot-translator#204
List of changes:
src/tensors/cpu/wasm_intgemm_fallback.cppfile) in marian-dev for wasm target and export it from marian wasm modulePlease note that for integer 16-bit matrix multiplication, the wasm target still uses intgemm (we are not aborting for integer 16-bit matrix multiplication).
Added dependencies: none
How to test
Follow the README instructions to run the wasm test page and observe the abort messages in browser console logs.
Checklist