Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import matrix-multiply from a separate wasm module #204

Closed
7 tasks done
Tracked by #205
abhi-agg opened this issue Jul 14, 2021 · 0 comments · Fixed by #232
Closed
7 tasks done
Tracked by #205

Import matrix-multiply from a separate wasm module #204

abhi-agg opened this issue Jul 14, 2021 · 0 comments · Fixed by #232
Assignees

Comments

@abhi-agg
Copy link
Contributor

abhi-agg commented Jul 14, 2021

For generic matrix multiply interface:

  • Restructure marian-dev, allowing it to import different implementations of generic matrix multiply interface for wasm target
  • Add a fallback (a polyfill) dummy implementation of this interface in marian-dev for wasm target and export it from marian wasm module
    • The fallback dummy implementation can throw initially
  • Change emscripten generated JS glue code to plug in this fallback implementation (until an optimized implementation is not landed in Firefox)
  • Verify the restructuring by running wasm artifacts on wasm test page
  • Provide a valid (non-dummy) fallback implementations for entire interface

bergamot-translator:

We want to support the fastest configuration --int8shiftAlphaAll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant