Bug/bundling errors swallowed #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmowrer
force-pushed
the
bug/bundling-errors-swallowed
branch
from
a8372ba to
41baa5c
Compare
pmowrer
force-pushed
the
bug/bundling-errors-swallowed
branch
from
41baa5c to
9ddf430
Compare
|
I'm not sure about this. This makes the bundle stream emit errors twice. The tests should be failing for you. |
|
You're right, this is mainly confusion on my part. I never realized errors were meant to be handled in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduces #266. To fix, emit
errorfrom thewatchifybundle.