Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundling errors are swallowed #266

Closed
pmowrer opened this issue Sep 14, 2015 · 1 comment
Closed

Bundling errors are swallowed #266

pmowrer opened this issue Sep 14, 2015 · 1 comment

Comments

@pmowrer
Copy link

pmowrer commented Sep 14, 2015

The bundle's error event is captured by watchify as of 847c549, but the event isn't re-emitted. This effectively swallows bundling errors.

My use case:
Using browserify + watchify as part of a gulp build. Bundling errors used to interrupt gulp as an unhandled event. As of 3.3.1, bundling just silently fails.
pmowrer added a commit to pmowrer/watchify that referenced this issue Sep 14, 2015
@pmowrer
Add failing test to reproduce swallowed bundling errors
f6fb4bf 
Reproduces browserify#266
pmowrer added a commit to pmowrer/watchify that referenced this issue Sep 14, 2015
@pmowrer
Fix bundling errors being swallowed
a8372ba 
Fixes browserify#266
@pmowrer pmowrer mentioned this issue Sep 14, 2015
Closed
pmowrer added a commit to pmowrer/watchify that referenced this issue Sep 14, 2015
@pmowrer
Fix bundling errors being swallowed
41baa5c 
Fixes browserify#266
pmowrer added a commit to pmowrer/watchify that referenced this issue Sep 14, 2015
@pmowrer
Add failing test to reproduce swallowed bundling errors
37d0e57 
Reproduces browserify#266
pmowrer added a commit to pmowrer/watchify that referenced this issue Sep 14, 2015
@pmowrer
Fix bundling errors being swallowed
9ddf430 
Fixes browserify#266
@pmowrer
Copy link
Author

pmowrer commented Sep 14, 2015

Closing per discussion in PR.

@pmowrer pmowrer closed this as completed Sep 14, 2015
@menzow menzow mentioned this issue Nov 17, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pmowrer