fix --class-name & some other options #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
changed the title
added 2 commits
April 1, 2020 18:50
- export & document `--class-name` CLI option - document `className` library API option - update description of `prefix` option - fix description of `modulePrefix` - remove an "option NOT DOCUMENTED & NOT SUPPORTED" comment
brody4hire
force-pushed
the
fix-class-name-and-module-prefix
branch
from
f4f82dd to
c5e6c2f
Compare
brody4hire
pushed a commit
that referenced
this pull request
Apr 2, 2020
This reverts commit 7c72990.
brody4hire
pushed a commit
that referenced
this pull request
Apr 2, 2020
This reverts commit 7c72990. It is desired to use a different name such as --object-name or --native-object-name rather than --class-name. The next step is to revisit the changes to the descriptions of the --prefix & --module-prefix options.
brody4hire
pushed a commit
that referenced
this pull request
Apr 2, 2020
This reverts commit 7c72990. It is desired to use a different name such as --object-name or --native-object-name rather than --class-name. The next step is to revisit the changes to the descriptions of the --prefix & --module-prefix options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated:
--class-nameCLI optionprefixoptionUndocumented
classNameoption was discovered inlib/normalized-options.jsduring cleanup removal of obsoletenamespaceoption in PR #276 (followup fix to PR #264 to remove Windows (C#) support)Testing:
P.S. Update needed to description of modulePrefix was discovered while working on the undocumented
classNameoption.