remove Windows (C#) support #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brody4hire
commented
Mar 2, 2020
brody4hire
force-pushed
the
remove-windows-platform-support
branch
from
ffb42ee to
d99e4a4
Compare
brody4hire
changed the title
brody4hire
changed the title
brody4hire
changed the title
brody4hire
changed the title
added 13 commits
March 2, 2020 11:36
OVERVIEW: Windows is no longer supported for reasons discussed in #23 & #43 Moving the existing Windows C# template into `unsupported-platforms`, will continue to be validated by the test suite for now (at least). Removing the `uuid` package dependency which is no longer needed (unless it is used for a supported platform again, someday). Further discussion would be welcome *in a new issue* on GitHub.
(and updated test snapshots)
brody4hire
changed the title
brody4hire
force-pushed
the
remove-windows-platform-support
branch
from
1db3d55 to
ce7f07b
Compare
added 2 commits
March 2, 2020 13:04
which is no longer needed now that Windows platform support is gone as discovered through mutation testing using Stryker Mutator
moving "unsupported-platforms" tests very carefully to preserve the test coverage while avoiding excess test snapshot churn in the git history
4 tasks
brody4hire
pushed a commit
that referenced
this pull request
Mar 3, 2020
followup to 0de40fa - remove Windows (C#) support (PR #264) namespace parameter is commented out for now, at least removed from library API since Windows platform is no longer supported Note that it should be possible to add Windows platform support and support the namespace parameter at some point in the future.
brody4hire
pushed a commit
that referenced
this pull request
Mar 3, 2020
followup to 0de40fa - remove Windows (C#) support (PR #264) extra namespace parameter no longer needed was discovered through mutation testing using Stryker Mutator (as reported in issue #274) namespace parameter is commented out for now, at least removed from library API since Windows platform is no longer supported Note that it should be possible to add Windows platform support and support the namespace parameter at some point in the future.
brody4hire
pushed a commit
that referenced
this pull request
Mar 3, 2020
* remove library API support for namespace followup to 0de40fa - remove Windows (C#) support (PR #264) extra namespace parameter no longer needed was discovered through mutation testing using Stryker Mutator (as reported in issue #274) namespace parameter is commented out for now, at least removed from library API since Windows platform is no longer supported Note that it should be possible to add Windows platform support and support the namespace parameter at some point in the future. * update a related comment * add another blank line to the affected code * update an error logging test snapshot
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated:
Windows is no longer supported for reasons discussed in #23 & #43
Moving the existing Windows C# template into
unsupported-platforms, will continue to be validated by the test suite for now (at least).Moving "unsupported-platforms" tests very carefully to preserve the test coverage while avoiding excess test snapshot churn in the git history.
Removing the
uuidpackage dependency which is no longer needed (unless it is used for a supported platform again, someday).Further discussion would be welcome in a new issue on GitHub.
✅
npm testok✅ able to generate library module with an example, tested on Android & iOS
✅ able to generate view module with an example, tested on Android & iOS
closes #23
closes #43