Adding additional operations #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
SparshithNR
commented
Dec 6, 2019
SparshithNR
commented
- Added rmdirSync with recursive:true
- Added unlinkSync, symlinkOrCopySync
- Added tests for the same
- Added README changes
SparshithNR
force-pushed
the
more-operations
branch
2 times, most recently
from
faed8a0 to
61e46ea
Compare
stefanpenner
reviewed
Dec 6, 2019
SparshithNR
force-pushed
the
more-operations
branch
from
61e46ea to
0924e81
Compare
stefanpenner
approved these changes
Dec 6, 2019
1. Added rmdirSync with recursive:true 2. Added unlinkSync, symlinkOrCopySync 3. Added tests for the same 4. Added README changes 5. Update package version
SparshithNR
force-pushed
the
more-operations
branch
from
0924e81 to
af442ba
Compare
rwjblue
reviewed
Dec 6, 2019
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "broccoli-output-wrapper", | |||
| "version": "3.0.0", | |||
| "version": "3.1.0", | |||
There was a problem hiding this comment.
FWIW, it's generally better to leave the version number until you are ready to actually publish. That's my process at least...
There was a problem hiding this comment.
I should also follow that too. I am simply bumping versions that I don't like. I will make a note of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.