Migrating to input/output facade #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SparshithNR good points! for 1) let's implement/provide a Doing 1) 2) 3) will add lots of value, good find! |
|
Depends on broccolijs/broccoli-output-wrapper#4 |
stefanpenner
requested changes
Dec 9, 2019
|
@SparshithNR is this pending update of broccoli-output-wrapper? |
|
|
|
Windows failures are due to fixed, but not yet released, node version. Context: #119 |
|
released as v3.0.1 🎉 |
ef4
added a commit
to ef4/broccoli-funnel
that referenced
this pull request
Mar 30, 2021
PR broccolijs#120 broke the case when you have both `srcDir` and some filtering options like `exclude`. The included test demonstrates the bug. It crashes during `processFile` because the `sourcePath` doesn't exist. This PR fixes the bug by restoring the correct relative paths as inputs to `walkSync`.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not complete migration as we are missing operations like
removeSyncis fromfs-extra,fs.rmdirhasrecursive:trueoption, but node 12 onwards.unlinkSyncneeds to be added tobroccoli-output-wrapperhttps://github.com/SparshithNR/broccoli-output-wrapper#apissymlinkOrCopyis one more method that is used extensively. Do we want to support that as well?