-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LocusWalkerSpark drops intervals with no reads #5222
Conversation
0395cf1
to
670223f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomwhite I have reviewed the CollectAllelicCountsSpark piece of this PR. The changes look reasonable. Thanks for rebasing, as well.
@tomwhite The other changes should probably be reviewed by someone else on the engine team. |
@LeeTL1220 thanks for the review! I'll work with the engine team to get the other parts reviewed. |
@jamesemery, yes, I've opened #5248 with the isolated fix (and unit test). I'll leave this open for the |
670223f
to
94c5a73
Compare
Now that #5127 and #5221 have gone in I've rebased this. Note that it will fail until the fix (which I moved to #5248 on @jamesemery's suggestion) has gone in. |
* Spark version of collect allelic counts spark. * Add ExampleLocusWalkerSpark.java and test
This PR fixes #3823 opened by @LeeTL1220
There are several series of commits applied here:
ll_CollectAllelicCountsSpark
onmaster
.CollectAllelicCountsSpark
work onmaster
.ExampleLocusWalkerSpark
in addition to the one forCollectAllelicCountsSpark
.The problem was that
emitEmptyLoci()
inLocusWalkerSpark
was not working properly. Any intervals that didn't overlap with reads were being dropped, which meant that those loci were not being passed to theLocusWalkerSpark
subclass.