Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn back on checking variant info fields against header in SV vcf writing #5084

Merged
merged 1 commit into from
Aug 3, 2018

Conversation

SHuang-Broad
Copy link
Contributor

turned off temporarily long time ago but slipped attention after implementation stablelized

…cf writing (turned off temporarily long time ago but slipped attention after implementation stablized)
@codecov-io
Copy link

Codecov Report

Merging #5084 into master will increase coverage by 0.004%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##              master     #5084       +/-   ##
===============================================
+ Coverage     86.387%   86.391%   +0.004%     
- Complexity     28815     28817        +2     
===============================================
  Files           1791      1791               
  Lines         133696    133695        -1     
  Branches       14896     14896               
===============================================
+ Hits          115496    115500        +4     
+ Misses         12797     12792        -5     
  Partials        5403      5403
Impacted Files Coverage Δ Complexity Δ
...e/hellbender/tools/spark/sv/utils/SVVCFWriter.java 86.957% <ø> (-0.278%) 11 <0> (ø)
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 60% <0%> (ø) 2% <0%> (ø) ⬇️
...e/hellbender/engine/spark/SparkContextFactory.java 73.973% <0%> (+2.74%) 11% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 80% <0%> (+30%) 3% <0%> (+2%) ⬆️

Copy link
Member

@cwhelan cwhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cwhelan cwhelan merged commit 6456cc4 into master Aug 3, 2018
@SHuang-Broad SHuang-Broad deleted the sh-sv-vcf-info-key-check branch August 3, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants