feat(terraform): add CKV NCP check about NKS(kubernetes) logging

checkov/terraform/checks/resource/ncp/NKSControlPlaneLogging.py

@@ -0,0 +1,17 @@
+from checkov.common.models.enums import CheckCategories
+from checkov.terraform.checks.resource.base_resource_value_check import BaseResourceValueCheck
+
+
+class NKSControlPlaneLogging(BaseResourceValueCheck):
+    def __init__(self):
+        name = "Ensure NKS control plane logging enabled for all log types"
+        id = "CKV_NCP_22"
+        supported_resources = ('ncloud_nks_cluster',)
+        categories = (CheckCategories.KUBERNETES,)
+        super().__init__(name=name, id=id, categories=categories, supported_resources=supported_resources)
+
+    def get_inspected_key(self):
+        return 'log/0/audit/0'
+
+
+check = NKSControlPlaneLogging()

tests/terraform/checks/resource/ncp/example_NKSControlPlaneLogging/main.tf

@@ -0,0 +1,42 @@
+resource "ncloud_nks_cluster" "pass" {
+  cluster_type                = "SVR.VNKS.STAND.C002.M008.NET.SSD.B050.G002"
+  k8s_version                 = data.ncloud_nks_versions.version.versions.0.value
+  login_key_name              = ncloud_login_key.loginkey.key_name
+  name                        = "sample-cluster"
+  lb_private_subnet_no        = ncloud_subnet.subnet_lb.id
+  kube_network_plugin         = "cilium"
+  subnet_no_list              = [ ncloud_subnet.subnet.id ]
+  vpc_no                      = ncloud_vpc.vpc.id
+  zone                        = "KR-1"
+  public_network = false
+  log {
+    audit = true
+  }
+}
+resource "ncloud_nks_cluster" "fail" {
+  cluster_type                = "SVR.VNKS.STAND.C002.M008.NET.SSD.B050.G002"
+  k8s_version                 = data.ncloud_nks_versions.version.versions.0.value
+  login_key_name              = ncloud_login_key.loginkey.key_name
+  name                        = "sample-cluster"
+  lb_private_subnet_no        = ncloud_subnet.subnet_lb.id
+  kube_network_plugin         = "cilium"
+  subnet_no_list              = [ ncloud_subnet.subnet.id ]
+  vpc_no                      = ncloud_vpc.vpc.id
+  zone                        = "KR-1"
+  public_network = false
+  log {
+    audit = false
+  }
+}
+resource "ncloud_nks_cluster" "fail2" {
+  cluster_type                = "SVR.VNKS.STAND.C002.M008.NET.SSD.B050.G002"
+  k8s_version                 = data.ncloud_nks_versions.version.versions.0.value
+  login_key_name              = ncloud_login_key.loginkey.key_name
+  name                        = "sample-cluster"
+  lb_private_subnet_no        = ncloud_subnet.subnet_lb.id
+  kube_network_plugin         = "cilium"
+  subnet_no_list              = [ ncloud_subnet.subnet.id ]
+  vpc_no                      = ncloud_vpc.vpc.id
+  zone                        = "KR-1"
+  public_network = false
+}

tests/terraform/checks/resource/ncp/test_NKSControlPlaneLogging.py

@@ -0,0 +1,41 @@
+import unittest
+from pathlib import Path
+
+from checkov.runner_filter import RunnerFilter
+from checkov.terraform.checks.resource.ncp.NKSControlPlaneLogging import check
+from checkov.terraform.runner import Runner
+
+
+class TestNKSControlPlaneLogging(unittest.TestCase):
+    def test(self):
+        # given
+        test_files_dir = Path(__file__).parent / "example_NKSControlPlaneLogging"
+
+        # when
+        report = Runner().run(root_folder=str(test_files_dir), runner_filter=RunnerFilter(checks=[check.id]))
+
+        # then
+        summary = report.get_summary()
+
+        passing_resources = {
+            "ncloud_nks_cluster.pass",
+        }
+        failing_resources = {
+            "ncloud_nks_cluster.fail",
+            "ncloud_nks_cluster.fail2",
+        }
+
+        passed_check_resources = {c.resource for c in report.passed_checks}
+        failed_check_resources = {c.resource for c in report.failed_checks}
+
+        self.assertEqual(summary["passed"], 1)
+        self.assertEqual(summary["failed"], 2)
+        self.assertEqual(summary["skipped"], 0)
+        self.assertEqual(summary["parsing_errors"], 0)
+
+        self.assertEqual(passing_resources, passed_check_resources)
+        self.assertEqual(failing_resources, failed_check_resources)
+
+
+if __name__ == "__main__":
+    unittest.main()