feat(terraform): add CKV NCP check about NKS(kubernetes) logging #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruebel
reviewed
Nov 19, 2022
| from checkov.terraform.checks.resource.base_resource_value_check import BaseResourceCheck | ||
|
|
||
|
|
||
| class NKSControlPlaneLogging(BaseResourceCheck): |
There was a problem hiding this comment.
would be great if you can change it to a BaseResourceValueCheck, makes it much easier 🙂
There was a problem hiding this comment.
thank your advice. I fixed my code.
gruebel
reviewed
Nov 21, 2022
checkov/terraform/checks/resource/ncp/NKSControlPlaneLogging.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Anton Grübel <[email protected]>
gruebel
changed the title
|
hey @pj991207 can you commit something in and out again, somehow the workflow was not triggered. |
ChanochShayner
approved these changes
Nov 24, 2022
mayblo
pushed a commit
to cider-rnd/checkov
that referenced
this pull request
Nov 24, 2022
…dgecrewio#3855) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.01][add]NksPublicAccess * [22.11.01][delete]ncp-13 rule * [22.11.01][fix]NksPublicAccess Description fix * [22.11.01][fix] test_NksPublicAccess.py * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.06][addNCP_LBNetworkPrivate * [22.11.08][add]CKV_NCP_18 * [22.11.08][add]NCP_CKV_39 * [22.11.08][fix]CKV_NCP_21 * [22.11.08][delete]CKVP_NCP_15 * [22.11.08]CKV_NCP_32 * Revert "[22.11.08]CKV_NCP_32" This reverts commit c3aa017. * [22.11.08][add]CKV_NCP_32 * Revert "[22.11.08][add]CKV_NCP_32" This reverts commit b7341f7. * [22.11.12][fix]CKV_NCP_27 * [22.11.12][fix]CKV_NCP_27 * [22.11.14][fix]NCP_CKV_19 * [22.11.16]CKV_NCP_19 BaseResourceNegativeValueCheck * [22.11.16][delet]CKV_NCP_27 * [22.11.21][fix]CKV_NCP_21 * Update checkov/terraform/checks/resource/ncp/NKSControlPlaneLogging.py Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Kuemjong Jeong <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
mayblo
pushed a commit
to cider-rnd/checkov
that referenced
this pull request
Nov 24, 2022
…dgecrewio#3855) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.01][add]NksPublicAccess * [22.11.01][delete]ncp-13 rule * [22.11.01][fix]NksPublicAccess Description fix * [22.11.01][fix] test_NksPublicAccess.py * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.06][addNCP_LBNetworkPrivate * [22.11.08][add]CKV_NCP_18 * [22.11.08][add]NCP_CKV_39 * [22.11.08][fix]CKV_NCP_21 * [22.11.08][delete]CKVP_NCP_15 * [22.11.08]CKV_NCP_32 * Revert "[22.11.08]CKV_NCP_32" This reverts commit c3aa017. * [22.11.08][add]CKV_NCP_32 * Revert "[22.11.08][add]CKV_NCP_32" This reverts commit b7341f7. * [22.11.12][fix]CKV_NCP_27 * [22.11.12][fix]CKV_NCP_27 * [22.11.14][fix]NCP_CKV_19 * [22.11.16]CKV_NCP_19 BaseResourceNegativeValueCheck * [22.11.16][delet]CKV_NCP_27 * [22.11.21][fix]CKV_NCP_21 * Update checkov/terraform/checks/resource/ncp/NKSControlPlaneLogging.py Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Kuemjong Jeong <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
mayblo
pushed a commit
to cider-rnd/checkov
that referenced
this pull request
Nov 24, 2022
…dgecrewio#3855) * [22.10.27][add]LBListenerUsesSecureProtocols * [22.11.01][add]NksPublicAccess * [22.11.01][delete]ncp-13 rule * [22.11.01][fix]NksPublicAccess Description fix * [22.11.01][fix] test_NksPublicAccess.py * [22.11.05][add]NCP_LBTargetGroupUsingHTTPS * [22.11.05][delete]ncp_13_rule * [22.11.06][addNCP_LBNetworkPrivate * [22.11.08][add]CKV_NCP_18 * [22.11.08][add]NCP_CKV_39 * [22.11.08][fix]CKV_NCP_21 * [22.11.08][delete]CKVP_NCP_15 * [22.11.08]CKV_NCP_32 * Revert "[22.11.08]CKV_NCP_32" This reverts commit c3aa017. * [22.11.08][add]CKV_NCP_32 * Revert "[22.11.08][add]CKV_NCP_32" This reverts commit b7341f7. * [22.11.12][fix]CKV_NCP_27 * [22.11.12][fix]CKV_NCP_27 * [22.11.14][fix]NCP_CKV_19 * [22.11.16]CKV_NCP_19 BaseResourceNegativeValueCheck * [22.11.16][delet]CKV_NCP_27 * [22.11.21][fix]CKV_NCP_21 * Update checkov/terraform/checks/resource/ncp/NKSControlPlaneLogging.py Co-authored-by: Anton Grübel <[email protected]> Co-authored-by: Kuemjong Jeong <[email protected]> Co-authored-by: Anton Grübel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Add terraform scan rules about provider Naver Cloud Platform.
CKV_NCP_21 is associated with "NKS control plane logging enabled for all log types"
Description
https://registry.terraform.io/providers/NaverCloudPlatform/ncloud/latest/docs/resources/nks_cluster
Checklist: