Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): handle unexpected value for enabled_cloudwatch_logs_exports #3638

Merged
merged 2 commits into from
Oct 11, 2022
Merged

fix(terraform): handle unexpected value for enabled_cloudwatch_logs_exports #3638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3794498
handle unexpected value for enabled_cloudwatch_logs_exports
PelegLi Oct 11, 2022
8c53cbd
PR comment
PelegLi Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions checkov/terraform/checks/resource/aws/DBInstanceLogging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,10 @@ def get_inspected_key(self) -> str:
return "enabled_cloudwatch_logs_exports/[0]"

def scan_resource_conf(self, conf: Dict[str, List[Any]]) -> CheckResult:
logs_exports = conf.get('enabled_cloudwatch_logs_exports', [[]])[0]
return CheckResult.PASSED if logs_exports else CheckResult.FAILED
logs_exports = conf.get('enabled_cloudwatch_logs_exports', [[]])
if not logs_exports:
return CheckResult.FAILED
return CheckResult.PASSED if logs_exports[0] else CheckResult.FAILED

def get_expected_value(self) -> Any:
return ANY_VALUE
Expand Down