Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(terraform): handle unexpected value for enabled_cloudwatch_logs_exports #3638

Merged
merged 2 commits into from
Oct 11, 2022
Merged

fix(terraform): handle unexpected value for enabled_cloudwatch_logs_exports #3638

merged 2 commits into from
Oct 11, 2022

Conversation

PelegLi
Copy link
Contributor

@PelegLi PelegLi commented Oct 11, 2022

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Handled an unexpected value in DBInstanceLogging check for enabled_cloudwatch_logs_exports.
No UT added for this specific case since I could not reproduce the template that caused this value (empty list).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

gruebel
gruebel approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@gruebel gruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small suggestion, otherwise good to go 🚀

checkov/terraform/checks/resource/aws/DBInstanceLogging.py Outdated Show resolved Hide resolved
@PelegLi PelegLi merged commit d67da44 into master Oct 11, 2022
@PelegLi PelegLi deleted the handle-unexpected-value-in-DBInstanceLogging branch October 11, 2022 09:44
Floodnut pushed a commit to init-cloud/checkov that referenced this pull request Oct 11, 2022
@PelegLi @schosterbarak
fix(terraform): handle unexpected value for enabled_cloudwatch_logs_e…
e2fafd5 
…xports (bridgecrewio#3638)

* handle unexpected value for enabled_cloudwatch_logs_exports

* PR comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruebel gruebel gruebel approved these changes

@tronxd tronxd tronxd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PelegLi @tronxd @gruebel