Use armv7 for android build on travis. #488
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage remained the same at 93.697% when pulling da152ccbaac158ec3e964305cdc5db5a37a19ad5 on pietro:travis-android-armv7 into d9d662f on briansmith:master. |
pietro
force-pushed
the
travis-android-armv7
branch
from
da152cc to
b6d1e52
Compare
I agree to license my contributions to each file under the terms given at the top of each file I changed.
pietro
force-pushed
the
travis-android-armv7
branch
from
b6d1e52 to
612f027
Compare
|
Changes Unknown when pulling 612f027 on pietro:travis-android-armv7 into ** on briansmith:master**. |
|
Changes Unknown when pulling 612f027 on pietro:travis-android-armv7 into ** on briansmith:master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that just by changing the target these flags,
-march=armv7-aandmfpu=vfpv3-d16, get passed to gcc. According to this we should also pass-mfloat-abi=softfp. We may also want to pass-thumband-mfpu=neonand lean on on the runtime detection for arm cpu features. There's also the recommended flags to the linker that we may want to pass to both gcc and rustc.