Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from arm-android-linuxeabi to armv7-android-linuxeabi on Travis CI #482

Closed
briansmith opened this issue Mar 10, 2017 · 5 comments
Closed

Comments

@briansmith
Copy link
Owner

I think we should switch to armv7-android-linuxeabi, because it is built with -mthumb (IIUC), whereas arm-android-linuxeabi isn't. We'd need to ensure that -mthumb gets passed to the C and C++ compilers and the assembler properly.

WDYT @pietro?

@briansmith
Copy link
Owner Author

briansmith commented Mar 10, 2017

See https://internals.rust-lang.org/t/what-is-the-current-status-of-arm-linux-androideabi/4507/3:

When the armv7-android-linuxeabi target was added, the plan was to eventually change Rust's arm-linux-androideabi target to no longer target ARMv7 but instead to match Android's armeabi ABI. This wasn't done immediately in order to allow time for existing crates to migrate to the new ARMv7 target. That was about six months ago; it's probably a good time to push forward with this.

@pietro
Copy link
Contributor

pietro commented Mar 10, 2017

I was about to write a comment in one of the android issues about that. I think we need to pass-march on #480 because the target is set to arm-android-linuxeabi instead of armv7-android-linuxeabi. We should be able to pass -mthumb too. I'll work on this issue and the compiler flags after clang on android lands.

@briansmith
Copy link
Owner Author

What you're suggesting sounds good to me, IIUC.

@pietro
Copy link
Contributor

pietro commented Mar 16, 2017

I didn't have time to figure out why building with clang for android fails so I went ahead and switched travis to armv7 on #488. I'll work on #486 before resuming working on clang.

@briansmith
Copy link
Owner Author

Fixed by #488. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants