LPS-121903 Migrate v2 usages in roles/roles-admin-web #99554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2021 08:50
Until now, in order to display the "creation" button (which is the button with a "+" icon), we have to pass a "creationMenu" object. In some cases we just want to show the creation button and handle it's click event listener - so this is what this change does.
The <clay:management-toolbar-v2 /> tag has been replaced with the
<clay:management-toolbar /> tag (which uses clay v3).
**Test plan**:
- From the global menu, select the **Control Panel** tab
- Navigate to **Roles**
- Make sure you can:
- Create and delete Regular Roles
- Create and delete Site Roles
- Create and delete Organization Roles
- Create and delete Asset Library Roles
- Create and delete Account Roles
- Create a Regular Role
- Select (click) the Regular Role you created previously
- Navigate to the **Assignees** tab
- Make sure you can add assignees from this role
- Make sure you can remove assignees from this role
|
To conserve resources, the PR Tester does not automatically run for forwarded pull requests. |
|
Merged. Thank you. |
liferay-continuous-integration
deleted the
ci-forward-LPS-121903-pr-835-sender-julien-ts-1614949202437
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwarded from: liferay-frontend#835 (Took 1
ci:forwardattempt in 3 hours 20 minutes)@julien
@liferay-frontend
Original pull request comment:
The <clay:management-toolbar-v2 /> tag has been replaced with the
<clay:management-toolbar /> tag (which uses clay v3).
Creating and deleting roles should work as expected, as well as adding or
removing assignees from these roles.
Test plan (1):
Test Plan (2):
Additional notes
Submitting this as a draft before forwarding to @drewbrokke so that @ambrinchaudhary , @john-co and @markocikos can review
This module had an
<aui:script>that was defining one of the management toolbar's event handler, and at the same time calling that handler depending on values present in session storage. Since this might be hard to understand, this is what I'm referring to.In this change, what I've done is replaced that by using a "propsTransformer" for the management toolbar, another JS module that defines the
addAssigneesfunction and a<liferay-frontend:component>to check session storage and conditionally call theaddAssigneesfunction.I think this is OK and I've actually mentioned it to @drewbrokke to make sure, but I'm adding this here so that everyone following this pull request thread knows why this change was made.
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: c7640fbeeaefafecf0ddea7d37985c7ccb701b58
Sender Branch:
Branch Name: LPS-121903
1 out of 1jobs PASSEDBranch GIT ID: 5bcc6f118883e1ff70a42432c591edd41789f370
1 Successful Jobs:
For more details click here.
✔️ ci:test:stable - 9 out of 9 jobs passed
✔️ ci:test:relevant - 23 out of 24 jobs passed in 3 hours 4 minutes
Click here for more details.
Base Branch:
Branch Name: master
Branch GIT ID: 7deedb562a6145be11b327fc35f9693b6b4e1541
Upstream Comparison:
Branch GIT ID: 7deedb562a6145be11b327fc35f9693b6b4e1541
Jenkins Build URL: Acceptance Upstream DXP (master) #1608
ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
2 Failed Jobs:
test-portal-acceptance-pullrequest(master)test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/022 Successful Jobs:
For more details click here.
This pull contains no unique failures.
Failures in common with acceptance upstream results at 7deedb5:
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
63 Tests Passed.
3 Tests Failed.