Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] curl 8.6.0 #1729

Merged
merged 2 commits into from
Jan 31, 2024
Merged

[1.x] curl 8.6.0 #1729

merged 2 commits into from
Jan 31, 2024

Conversation

GrahamCampbell
Copy link
Contributor

@GrahamCampbell GrahamCampbell commented Jan 31, 2024

Prior to cURL 8.6.0, configure would silently skip when libpsl was missing, compiling without support for public suffix lists. Probably it's not a good idea to start making arguably breaking changes in Bref v1 at this point, and so I've added in the configure flag to continue to ignore the fact that libpsl is missing. For Bref v2 (brefphp/aws-lambda-layers#157), I'll try and get that library included.

@GrahamCampbell GrahamCampbell marked this pull request as ready for review January 31, 2024 10:12
@mnapoli
Copy link
Member

mnapoli commented Jan 31, 2024

Probably it's not a good idea to start making arguably breaking changes in Bref v1 at this point, and so I've added in the configure flag to continue to ignore the fact that libpsl is missing.

👍

Thanks!

@mnapoli mnapoli merged commit caa2cc3 into brefphp:1.x Jan 31, 2024
9 checks passed
@GrahamCampbell GrahamCampbell deleted the 1.x-curl-8-6-0 branch January 31, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants