curl 8.6.0 #157
curl 8.6.0 #157
Conversation
|
The failure says:
Any idea? |
GrahamCampbell
force-pushed
the
curl-8-6-0
branch
from
ba5c5d6
to
53b79e9
Compare
|
I've updated the PR description. ;) |
|
Got it! Looking at what psl is, and the fact that the website says it's 50MB, does that mean the layers will grow as well? |
|
Good question. Let me see... |
|
No. The image is ~0.3MB larger, only. |
|
Though possibly we need to manually copy additional files? |
|
That might be possible, any way to test that (and add an automated test)? |
|
Trying to set a cookie with domain |
|
I may not have time to do this today, but I don't think getting this curl upgrade out is particularly urgent. 🤷 |
|
I think 0.3MB is directionally correct though, for the size I would expect. Where did the 50MB number come from? |
|
Ah nevermind, I looked in the wrong place. I ended up looking at the sources and it seems to be using this list of domains: https://github.com/publicsuffix/list/blob/5db9b65997e3c9230ac4353b01994c2ae9667cb9/public_suffix_list.dat That's 250KB so we should be good, sounds consistent 👍 |
Prior to cURL 8.6.0, configure would silently skip when libpsl was missing, compiling without support for public suffix lists. For Bref v2 at least, I think it's probably a good idea to compile cURL with support for this, so I've added in a build step to compile libpsl.
For Bref v1 (brefphp/bref#1729), I'm not sure it's such a good idea to start making what is arguably a breaking change, so I've added in the configure flag to continue to ignore the fact that libpsl is missing.