Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 45: Do not proxy requests for Widevine #46

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Fix 45: Do not proxy requests for Widevine #46

merged 1 commit into from
Jun 17, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Jun 14, 2020

Fix #45

Test Plan:

  • With Browser

    • Navigate to https://bitmovin.com/demos/drm
    • Allow Widevine and verify the request for update is sent to update.googleapis.com
    • Ensure that the download is triggered from *.gvt1.com or *.dl.google.com
  • With curl:

% curl -Ls -o /dev/null -w '%{url_effective}' -d '{"request":{"@os":"mac","@updater":"","acceptformat":"crx2,crx3","app":[{"appid":"oimompecagnajdejgnnjijobebaeigek","enabled":true,"installsource":"ondemand","ping":{"r":-2},"updatecheck":{},"version":"0.0.0.0"}],"arch":"x64","dedup":"cr","domainjoined":false,"hw":{"physmemory":16},"lang":"","nacl_arch":"x86-64","os":{"arch":"x86_64","platform":"Mac OS X","version":"10.15.5"},"prodchannel":"stable","prodversion":"83.1.12.20","protocol":"3.1","requestid":"{67dd796c-ac2d-46f9-a56d-6495e7c92640}","sessionid":"{fd35f289-fb9a-4a7c-8acf-9576b1d0c5eb}","updaterchannel":"stable","updaterversion":"83.1.12.20"}}' -H "Content-Type: application/json" -X POST http://localhost:8192/extensions
https://update.googleapis.com/service/update2/json

@jumde jumde self-assigned this Jun 14, 2020
@jumde jumde requested review from bbondy and diracdeltas June 14, 2020 21:54
@jumde jumde force-pushed the widevine branch 4 times, most recently from 38af529 to dfbddcf Compare June 14, 2020 22:38
@kjozwiak
Copy link
Member

Went through QA via brave/brave-core#5846 (comment).

@jumde jumde merged commit b1297f7 into master Jun 17, 2020
@mihaiplesa mihaiplesa deleted the widevine branch January 6, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not proxy requests for Widevine
3 participants