Fix 10269: Do not proxy downloads for Widevine #5846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumde
changed the title
diracdeltas
approved these changes
Jun 16, 2020
bbondy
approved these changes
Jun 16, 2020
iefremov
reviewed
Jun 16, 2020
| auto request_info = std::make_shared<brave::BraveRequestInfo>(url); | ||
| int rc = | ||
| OnBeforeURLRequest_StaticRedirectWork(ResponseCallback(), request_info); | ||
| EXPECT_EQ(request_info->new_url_spec, base::EmptyString()); |
There was a problem hiding this comment.
prefer just "" instead of base::EmptyString, there is an explanation
// Therefore, DO NOT USE THESE AS A GENERAL-PURPOSE SUBSTITUTE FOR DEFAULT
// CONSTRUCTORS. There is only one case where you should use these: functions
// which need to return a string by reference (e.g. as a class member
// accessor), and don't have an empty string to use (e.g. in an error case).
iefremov
reviewed
Jun 16, 2020
| @@ -74,6 +74,13 @@ int OnBeforeURLRequest_StaticRedirectWorkForGURL( | |||
| URLPattern::SCHEME_HTTP | URLPattern::SCHEME_HTTPS, | |||
| "*://dl.google.com/*"); | |||
|
|
|||
| static URLPattern widevineGvt1_pattern( | |||
There was a problem hiding this comment.
most of names here don't match CC, I think it should be widevine_gvt1_pattern
There was a problem hiding this comment.
I filed this issue: brave/brave-browser#10314 - Will try to address this soon. Added a to-do to the code.
iefremov
approved these changes
Jun 16, 2020
jumde
force-pushed
the
widevine_download_exception
branch
from
7dc8e42
to
bdaa1f8
Compare
brave-builds
pushed a commit
that referenced
this pull request
Jun 16, 2020
brave-builds
pushed a commit
that referenced
this pull request
Jun 16, 2020
This was referenced Jun 16, 2020
|
Verification PASSED on
|
|
Verification passed on
Request JSON{
"request": {
"@os": "win",
"@updater": "",
"acceptformat": "crx2,crx3",
"app": [
{
"appid": "oimompecagnajdejgnnjijobebaeigek",
"event": [
{
"download_time_ms": 56269,
"downloaded": 5205379,
"downloader": "direct",
"eventresult": 1,
"eventtype": 14,
"nextversion": "4.10.1610.0",
"previousversion": "0.0.0.0",
"total": 5205379,
"url": "http://redirector.gvt1.com/edgedl/chromewebstore/L2Nocm9tZV9leHRlbnNpb24vYmxvYnMvNTQ2QUFXaFBmeHYtb0xmZjM3YU5MN0FwZw/4.10.1610.0_oimompecagnajdejgnnjijobebaeigek.crx"
},
{
"eventresult": 1,
"eventtype": 3,
"nextfp": "1.3a7afafe965da76cea59344022f69dcb9eaaef382ce56eb1daa8d20f9ec80c16",
"nextversion": "4.10.1610.0",
"previousversion": "0.0.0.0"
}
],
"version": "4.10.1610.0"
}
],
"arch": "x64",
"dedup": "cr",
"hw": {
"physmemory": 16
},
"lang": "",
"nacl_arch": "x86-64",
"os": {
"arch": "x86_64",
"platform": "Windows",
"version": "10.0.18363.900"
},
"prodchannel": "stable",
"prodversion": "83.1.12.31",
"protocol": "3.1",
"requestid": "{b76fc663-6970-45b7-b036-7faa9b3285a0}",
"sessionid": "{f57142d3-f09d-42bd-acee-ae61417c1723}",
"updaterchannel": "stable",
"updaterversion": "83.1.12.31"
}
}Response JSON{
"response": {
"server": "prod",
"protocol": "3.1",
"daystart": {
"elapsed_seconds": 84987,
"elapsed_days": 4915
},
"app": [
{
"appid": "oimompecagnajdejgnnjijobebaeigek",
"status": "ok",
"event": [
{
"status": "ok"
},
{
"status": "ok"
}
]
}
]
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#10269
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
--use-dev-goupdater-urlhttps://bitmovin.com/demos/drmupdate.googleapis.com*.gvt1.comand*.dl.google.comReviewer Checklist:
After-merge Checklist:
changes has landed on.