Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated BraveSearchPromotionBannerStudy (#946) #947

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

simonhong
Copy link
Member

issue: brave/brave-browser#36499

Removed type A banner from study.

@simonhong simonhong self-assigned this Mar 1, 2024
@simonhong simonhong requested a review from a team as a code owner March 1, 2024 04:16
@simonhong simonhong force-pushed the update_search_promotion_banner_study branch from f8c610a to 997339a Compare March 8, 2024 05:55
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the PR/Changes using Griffin on main (staging) as per #946 (comment). The BraveSearchPromotionBannerStudy has been enabled on Nightly since Oct 2023 as per https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1696368267325949.

@kjozwiak kjozwiak merged commit b4f6b81 into production Mar 11, 2024
3 checks passed
@kjozwiak kjozwiak deleted the update_search_promotion_banner_study branch March 11, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants