-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated BraveSearchPromotionBannerStudy #946
Conversation
issue: brave/brave-browser#36499 Removed type A banner from study.
issue: brave/brave-browser#36499 Removed type A banner from study.
issue: brave/brave-browser#36499 Removed type A banner from study.
As per #746 (comment), Griffin uses
|
Example |
Example |
Example |
---|---|---|
BraveSearchPromotionBannerStudy:banner_type_C
- CA
- downloaded/installed
1.65.73 Chromium: 123.0.6312.29
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy:banner_type_C
viabrave://version
- changed
SE
fromBrave
toGoogle
viabrave://settings/search
- typed
brave
into the omnibox and ensured that theSearch Promotion Banner
appears without any issues
Example |
Example |
Example |
---|---|---|
BraveSearchPromotionBannerStudy:banner_type_D
- CA
- downloaded/installed
1.65.73 Chromium: 123.0.6312.29
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy:banner_type_D
viabrave://version
- changed
SE
fromBrave
toGoogle
viabrave://settings/search
- typed
brave
into the omnibox and ensured that theSearch Promotion Banner
appears without any issues
Example |
Example |
Example |
---|---|---|
BraveSearchPromotionBannerStudy:banner_type_C
- DE
Quick Note:
Changed the language to DE
and also used a German IP
- downloaded/installed
1.65.73 Chromium: 123.0.6312.29
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy:banner_type_C
viabrave://version
- changed
SE
fromBrave
toGoogle
viabrave://settings/search
- typed
brave
into the omnibox and ensured that theSearch Promotion Banner
appears without any issues
Example |
Example |
Example |
---|---|---|
Win 11 x64
using BETA
verification(s):
Verification PASSED on Win 11 x64
using the following build(s):
Brave | 1.64.101 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
-- | --
Revision | e1a43a7a6dbf11e2ad76c70196247f0efc38a493
OS | Windows 11 Version 23H2 (Build 22631.3235)
BraveSearchPromotionBannerStudy:banner_type_B
- CA
- downloaded/installed
1.64.101 Chromium: 122.0.6261.111
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy:banner_type_B
viabrave://version
- changed
SE
fromBrave
toGoogle
viabrave://settings/search
- typed
brave
into the omnibox and ensured that theSearch Promotion Banner
appears without any issues
Example |
Example |
Example |
---|---|---|
BraveSearchPromotionBannerStudy:banner_type_C
- CA
- downloaded/installed
1.64.101 Chromium: 122.0.6261.111
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy:banner_type_C
viabrave://version
- changed
SE
fromBrave
toGoogle
viabrave://settings/search
- typed
brave
into the omnibox and ensured that theSearch Promotion Banner
appears without any issues
Example |
Example |
Example |
---|---|---|
BraveSearchPromotionBannerStudy:banner_type_D
- CA
- downloaded/installed
1.64.101 Chromium: 122.0.6261.111
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy:banner_type_D
viabrave://version
- changed
SE
fromBrave
toGoogle
viabrave://settings/search
- typed
brave
into the omnibox and ensured that theSearch Promotion Banner
appears without any issues
Example |
Example |
Example |
---|---|---|
BraveSearchPromotionBannerStudy:banner_type_B
- IN
Quick Note:
Changed the language to India
and also used a Indian IP
- downloaded/installed
1.64.101 Chromium: 122.0.6261.111
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy:banner_type_B
viabrave://version
- changed
SE
fromBrave
toGoogle
viabrave://settings/search
- typed
brave
into the omnibox and ensured that theSearch Promotion Banner
appears without any issues
Example |
Example |
Example |
---|---|---|
Win 11 x64
using Release
verification(s):
Verification PASSED on Win 11 x64
using the following build(s):
Brave | 1.63.169 Chromium: 122.0.6261.111 (Official Build) (64-bit)
-- | --
Revision | 0e0a975cf46d4d026e184ca61788e1da6f0d76bc
OS | Windows 11 Version 23H2 (Build 22631.3235)
BraveSearchPromotionBannerStudy
should be used (Only Nightly
& BETA
)
- downloaded/installed
1.63.169 Chromium: 122.0.6261.111
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible/being used underbrave://version
Win 11 x64
using BETA
verification(s):
Verification PASSED on Win 11 x64
using the following build(s):
Brave | 1.64.101 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
-- | --
Revision | e1a43a7a6dbf11e2ad76c70196247f0efc38a493
OS | Windows 11 Version 23H2 (Build 22631.3235)
BraveSearchPromotionBannerStudy
should be used (incorrect x-country
) - Poland
- downloaded/installed
1.63.169 Chromium: 122.0.6261.111
and startedBrave
using the followingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible underbrave://version
- restarted
Brave
usingbrave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
- ensured that
BraveSearchPromotionBannerStudy
isn't visible/being used underbrave://version
issue: brave/brave-browser#36499 Removed type A banner from study. Co-authored-by: Kamil Jozwiak <[email protected]>
issue: brave/brave-browser#36499
Removed type A banner from study.