Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated BraveSearchPromotionBannerStudy #946

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Updated BraveSearchPromotionBannerStudy #946

merged 1 commit into from
Mar 1, 2024

Conversation

simonhong
Copy link
Member

issue: brave/brave-browser#36499

Removed type A banner from study.

@simonhong
Updated BraveSearchPromotionBannerStudy
bb5f089 
issue: brave/brave-browser#36499

Removed type A banner from study.
@simonhong simonhong self-assigned this Mar 1, 2024
@simonhong simonhong requested a review from a team as a code owner March 1, 2024 04:08
@simonhong simonhong merged commit 573740a into main Mar 1, 2024
5 checks passed
@simonhong simonhong deleted the update_search_promotion_banner_study branch March 1, 2024 04:14
simonhong added a commit that referenced this pull request Mar 1, 2024
@simonhong
Updated BraveSearchPromotionBannerStudy (#946)
c672027 
issue: brave/brave-browser#36499

Removed type A banner from study.
simonhong added a commit that referenced this pull request Mar 8, 2024
@simonhong
Updated BraveSearchPromotionBannerStudy (#946)
997339a 
issue: brave/brave-browser#36499

Removed type A banner from study.
@kjozwiak
Copy link
Member

kjozwiak commented Mar 11, 2024 •
edited
Loading

Quick Note: As per #746 (comment), the bulk of the QA was completed via brave/brave-browser#31746 and then also checked while using Griffin as per #746 (comment). With the above, we'll ensure:

  • that BraveSearchPromotionBannerStudy:banner_type_A is not being used
  • do a quick spot check via CA to ensure that all the other banner types are being used/displayed correctly
  • do a quick spot check using another country other than CA to ensure that the banners are being displayed

As per #746 (comment), Griffin uses x-country so we'll need to use a VPN to change the IP to the supporting countries listed via https://github.com/brave/brave-variations/pull/946/files#diff-7ac2945ede68c73330363911678f6c9a2a6290b70e2dd170868295f65da7e872R768.

Win 11 x64 using Nightly verification(s):

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.65.73 Chromium: 123.0.6312.29 (Official Build) nightly (64-bit)
-- | --
Revision | 9cc34b8cfe9e8df8faede773545252783eefd953
OS | Windows 11 Version 23H2 (Build 22631.3235)

BraveSearchPromotionBannerStudy:banner_type_B - CA

  • downloaded/installed 1.65.73 Chromium: 123.0.6312.29 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy:banner_type_B via brave://version
  • changed SE from Brave to Google via brave://settings/search
  • typed brave into the omnibox and ensured that the Search Promotion Banner appears without any issues
Example Example Example
image image image

BraveSearchPromotionBannerStudy:banner_type_C - CA

  • downloaded/installed 1.65.73 Chromium: 123.0.6312.29 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy:banner_type_C via brave://version
  • changed SE from Brave to Google via brave://settings/search
  • typed brave into the omnibox and ensured that the Search Promotion Banner appears without any issues
Example Example Example
image image image

BraveSearchPromotionBannerStudy:banner_type_D - CA

  • downloaded/installed 1.65.73 Chromium: 123.0.6312.29 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy:banner_type_D via brave://version
  • changed SE from Brave to Google via brave://settings/search
  • typed brave into the omnibox and ensured that the Search Promotion Banner appears without any issues
Example Example Example
image image image

BraveSearchPromotionBannerStudy:banner_type_C - DE

Quick Note: Changed the language to DE and also used a German IP

  • downloaded/installed 1.65.73 Chromium: 123.0.6312.29 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy:banner_type_C via brave://version
  • changed SE from Brave to Google via brave://settings/search
  • typed brave into the omnibox and ensured that the Search Promotion Banner appears without any issues
Example Example Example
de1 de2 de3

Win 11 x64 using BETA verification(s):

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.64.101 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
-- | --
Revision | e1a43a7a6dbf11e2ad76c70196247f0efc38a493
OS | Windows 11 Version 23H2 (Build 22631.3235)

BraveSearchPromotionBannerStudy:banner_type_B - CA

  • downloaded/installed 1.64.101 Chromium: 122.0.6261.111 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy:banner_type_B via brave://version
  • changed SE from Brave to Google via brave://settings/search
  • typed brave into the omnibox and ensured that the Search Promotion Banner appears without any issues
Example Example Example
image image image

BraveSearchPromotionBannerStudy:banner_type_C - CA

  • downloaded/installed 1.64.101 Chromium: 122.0.6261.111 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy:banner_type_C via brave://version
  • changed SE from Brave to Google via brave://settings/search
  • typed brave into the omnibox and ensured that the Search Promotion Banner appears without any issues
Example Example Example
image image image

BraveSearchPromotionBannerStudy:banner_type_D - CA

  • downloaded/installed 1.64.101 Chromium: 122.0.6261.111 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy:banner_type_D via brave://version
  • changed SE from Brave to Google via brave://settings/search
  • typed brave into the omnibox and ensured that the Search Promotion Banner appears without any issues
Example Example Example
image image image

BraveSearchPromotionBannerStudy:banner_type_B - IN

Quick Note: Changed the language to India and also used a Indian IP

  • downloaded/installed 1.64.101 Chromium: 122.0.6261.111 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy:banner_type_B via brave://version
  • changed SE from Brave to Google via brave://settings/search
  • typed brave into the omnibox and ensured that the Search Promotion Banner appears without any issues
Example Example Example
IN1 IN2 IN3

Win 11 x64 using Release verification(s):

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.63.169 Chromium: 122.0.6261.111 (Official Build) (64-bit)
-- | --
Revision | 0e0a975cf46d4d026e184ca61788e1da6f0d76bc
OS | Windows 11 Version 23H2 (Build 22631.3235)

BraveSearchPromotionBannerStudy should be used (Only Nightly & BETA)

  • downloaded/installed 1.63.169 Chromium: 122.0.6261.111 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible/being used under brave://version

image

Win 11 x64 using BETA verification(s):

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.64.101 Chromium: 122.0.6261.111 (Official Build) beta (64-bit)
-- | --
Revision | e1a43a7a6dbf11e2ad76c70196247f0efc38a493
OS | Windows 11 Version 23H2 (Build 22631.3235)

BraveSearchPromotionBannerStudy should be used (incorrect x-country) - Poland

  • downloaded/installed 1.63.169 Chromium: 122.0.6261.111 and started Brave using the following
    • brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible under brave://version
  • restarted Brave using brave.exe --enable-logging=stderr --variations-server-url=https://variations.bravesoftware.com/seed
  • ensured that BraveSearchPromotionBannerStudy isn't visible/being used under brave://version

poland

@kjozwiak kjozwiak mentioned this pull request Mar 11, 2024
Merged
kjozwiak added a commit that referenced this pull request Mar 11, 2024
@simonhong @kjozwiak
Updated BraveSearchPromotionBannerStudy (#946) (#947)
b4f6b81 
issue: brave/brave-browser#36499

Removed type A banner from study.

Co-authored-by: Kamil Jozwiak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @kjozwiak