Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HangWatcher to nightly 50% #194

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

atuchin-m
Copy link
Collaborator

Nightly 50%, tested manually.
Security review: brave/security#659

What the study does?

  • enables sending crash dumps if a hang happens. The logic of hang detections are chromium and already works everywhere, but record only UMA.

What can go wrong? Is data loss possible?

  • A lot of dumps because a lot of hangs or false positives.

min_version is set to current nightly with landed brave/brave-browser#19822
(the changed description in the settings page).

PRs to master:
#192
#193

The root issue:
brave/brave-browser#20304

@atuchin-m atuchin-m requested a review from a team as a code owner January 5, 2022 16:12
@atuchin-m atuchin-m self-assigned this Jan 5, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Jan 7, 2022

Verification PASSED on Win 11 x64 using the following builds:

Brave | 1.36.22 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
-- | --
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | Windows 11 Version 21H2 (Build 22000.376)
Brave | 1.35.75 Chromium: 97.0.4692.71 (Official Build) beta (64-bit)
-- | --
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | Windows 11 Version 21H2 (Build 22000.376)
Brave | 1.34.80 Chromium: 97.0.4692.71 (Official Build) (64-bit)
-- | --
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | Windows 11 Version 21H2 (Build 22000.376)

STR/Cases:

  • ensured that both HangWatcher:HangWatcherEnableDumps & HangWatcher:Default are being used under Nightly
  • ensured that both HangWatcher:HangWatcherEnableDumps & HangWatcher:Default are not being used under Beta & Release
Nightly Enabled Nightly Disabled
NightlyEnabled NightlyDisabled

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into production for Nightly at 50% approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #194 (comment).

@kjozwiak kjozwiak merged commit 327093b into production Jan 10, 2022
@kjozwiak kjozwiak deleted the hang-watcher-nightly-50-plus-name-fix branch January 10, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants