Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the description for the setting Automatically sends crash reports to Brave #19822

Closed
atuchin-m opened this issue Nov 30, 2021 · 11 comments · Fixed by brave/brave-core#11360
Assignees
Labels
needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Test-All-Device-Types QA/Yes release-notes/include

Comments

@atuchin-m
Copy link
Contributor

atuchin-m commented Nov 30, 2021

We are planning toHangWatcher feature which send crash dump when browser hangs.
Before enabling the feature the text should be changed to something like Automatically sends crash reports and hangs to Brave

Existing
Screen Shot 2021-11-30 at 10 42 46 AM

Security review: https://github.com/brave/security/issues/659

@atuchin-m atuchin-m self-assigned this Nov 30, 2021
@atuchin-m
Copy link
Contributor Author

@kjozwiak Do we need to add release-notes/include here?

@stephendonner stephendonner added the needs-text-change This change requires some careful wording. label Nov 30, 2021
@rebron
Copy link
Collaborator

rebron commented Nov 30, 2021

cc: @rmcfadden3

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 30, 2021
@rmcfadden3
Copy link

@rebron — I feel like the term "Hangs" might not be fully understood. What about something like:

Header: Help improve Brave's features and performance
Body: Automatically send reports to Brave when the browser crashes or hangs on page load

@atuchin-m
Copy link
Contributor Author

ok. One nit: I suggest removing the last part on page load. Crashes/hangs can occur on startup/shutdown during page interaction (or even without it). Secondary processes (like gpu/audio/etc) also are taken into account.

Here is my proposal:
image

Also, the feature is relevant for Android too, so let's also change the text in android settings (the text is the same).

@atuchin-m atuchin-m added the OS/Android Fixes related to Android browser functionality label Dec 1, 2021
@rmcfadden3
Copy link

@atuchin-m — sure, that works for me. Let's go with what you have in your latest screenshot. I like it!

@atuchin-m
Copy link
Contributor Author

@rebron @akeane
Could you please verify the final screenshots here?
brave/brave-core#11360 (comment)

The discussion about texts: https://github.com/brave/brave-com-resources/issues/424#issuecomment-995031006

@rebron
Copy link
Collaborator

rebron commented Dec 30, 2021

@atuchin-m Looks good.

@atuchin-m
Copy link
Contributor Author

new keys are added:
IDS_BRAVE_DIAGNOSTIC_REPORTS_PREF
IDS_BRAVE_DIAGNOSTIC_REPORTS_PREF_DESC

keys changed:
IDS_FR_ENABLE_LOGGING
IDS_CRASH_REPORT_PERMISSION_ASK_DIALOG_CONTENT_TEXT
IDS_CRASH_REPORT_PERMISSION_ASK_DIALOG_FOOTNOTE_TEXT

@anthonypkeane
Copy link

@atuchin-m Looks good.

@stephendonner
Copy link

stephendonner commented Jan 7, 2022

Verified PASSED using

Brave 1.36.22 Chromium: 97.0.4692.71 (Official Build) nightly (x86_64)
Revision adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS macOS Version 11.6.1 (Build 20G224)

Confirmed the UI now reads "Help improve Brave's product stability by automatically sending diagnostic reports when the Brave Browser crashes or freezes."

before after
Screen Shot 2022-01-07 at 8 54 10 AM Screen Shot 2022-01-07 at 8 52 00 AM

@stephendonner
Copy link

stephendonner commented Jan 11, 2022

Verified PASSED using Brave 1.36.29, Chromium 97.0.4692.71 on a Google Pixel XL (arm64) running Android 9.0.

Confirmed it now reads, "Help improve Brave's product stability by automatically sending diagnostic reports when the Brave Browser crashes or freezes."

Screenshot_20220110-150953


Verification passed on Samsung Tab A with Android 10 running 1.36.105 x64 build

  • Verified the description is updated
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass-macOS QA/Test-All-Device-Types QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants