-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Ad Serving Version 2 for 50% of Nightly users #160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good to merge. Basic tests done for v1 and v2. Verification passed on
Ad serving v2Verified Ad serving v2 was used in griffin Verified notification ad was shown:
User was paid for it
Verified inline ad:
Verified user is paid for it:
Ad serving v1Verified notification ad:
Verified user was paid:
Verified inline ad
Verified user is paid:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uplift into production
approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #160 (comment).
No description provided.