Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to custom ad notifications on Windows and Android if native notifications are disabled #128

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Fallback to custom ad notifications on Windows and Android if native notifications are disabled #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 69 additions & 9 deletions seed/seed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,10 +547,6 @@
"name": "CustomAdNotificationPositionedBottomRightOffsetToTheLeftOfSystemNotifications",
"probability_weight": 30,
"parameters": [
{
"name": "can_fallback_to_custom_notifications",
"value": "true"
},
{
"name": "ad_notification_normalized_display_coordinate_x",
"value": "1.0"
Expand All @@ -575,32 +571,61 @@
{
"name": "CustomAdNotificationDefaultPosition",
"probability_weight": 30,
"feature_association": {
"enable_feature": ["CustomAdNotifications"]
}
},
{
"name": "Disabled",
"probability_weight": 0,
"feature_association": {
"disable_feature": ["CustomAdNotifications"]
}
},
{
"name": "Default",
"probability_weight": 40
}
],
"filter": {
"min_version": "92.1.30.19",
tmancey marked this conversation as resolved.
Show resolved Hide resolved
"min_os_version": "10.0.17134.*",
"channel": ["BETA", "NIGHTLY"],
"platform": ["WINDOWS"]
}
},
{
"name": "AdNotificationsWindowsStudy",
"experiments": [
{
"name": "Enabled",
"probability_weight": 100,
"parameters": [
{
"name": "can_fallback_to_custom_notifications",
"value": "true"
}
],
"feature_association": {
"enable_feature": ["CustomAdNotifications"]
"enable_feature": ["AdNotifications"]
}
},
{
"name": "Disabled",
"probability_weight": 0,
"feature_association": {
"disable_feature": ["CustomAdNotifications"]
"disable_feature": ["AdNotifications"]
}
},
{
"name": "Default",
"probability_weight": 40
"probability_weight": 0
}
],
"filter": {
"min_version": "92.1.30.19",
"min_version": "94.1.30.87",
"min_os_version": "10.0.17134.*",
"channel": ["BETA", "NIGHTLY"],
"channel": ["RELEASE", "BETA", "NIGHTLY"],
"platform": ["WINDOWS"]
}
},
Expand Down Expand Up @@ -773,6 +798,41 @@
"platform": ["ANDROID"]
}
},
{
"name": "AdNotificationsAndroidStudy",
"experiments": [
{
"name": "Enabled",
"probability_weight": 100,
"parameters": [
{
"name": "can_fallback_to_custom_notifications",
"value": "true"
}
],
"feature_association": {
"enable_feature": ["AdNotifications"]
}
},
{
"name": "Disabled",
"probability_weight": 0,
"feature_association": {
"disable_feature": ["AdNotifications"]
}
},
{
"name": "Default",
"probability_weight": 0
}
],
"filter": {
"min_version": "94.1.30.87",
"min_os_version": "8.*",
"channel": ["RELEASE", "BETA", "NIGHTLY"],
"platform": ["ANDROID"]
}
},
{
"name": "BraveAds.ShowCustomAdNotificationOnAndroidStudy",
"experiments": [
Expand Down