Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback to custom ad notifications on Windows and Android if native notifications are disabled #128

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Fallback to custom ad notifications on Windows and Android if native notifications are disabled #128

merged 1 commit into from
Oct 1, 2021

Conversation

tmancey
Copy link
Contributor

@tmancey tmancey commented Sep 24, 2021 •
edited
Loading

Fallback to custom ad notifications on Windows (10.0.17134 or above) and Android (8.0 or above) if native notifications are disabled

@tmancey tmancey self-assigned this Sep 24, 2021
@tmancey tmancey requested a review from a team as a code owner September 24, 2021 21:29
@tmancey tmancey changed the title Fallback to custom ad notifications on Windows and Android Fallback to custom ad notifications on Windows and Android if native notifications are disabled Sep 24, 2021
@tmancey tmancey force-pushed the can_fallback_on_windows_and_android branch from a16c2c2 to 70588a1 Compare September 24, 2021 21:38
tmancey
tmancey commented Sep 24, 2021
View reviewed changes
seed/seed.json Show resolved Hide resolved
tmancey
tmancey commented Sep 24, 2021
View reviewed changes
seed/seed.json Outdated Show resolved Hide resolved
goodov
goodov reviewed Sep 27, 2021
View reviewed changes
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for min_version changes

This was referenced Sep 27, 2021
Closed
Closed
@tmancey tmancey force-pushed the can_fallback_on_windows_and_android branch from 70588a1 to a9b178f Compare October 1, 2021 13:55
@tmancey tmancey force-pushed the can_fallback_on_windows_and_android branch from a9b178f to cb5baf6 Compare October 1, 2021 13:56
@tmancey tmancey requested a review from goodov October 1, 2021 14:06
@tmancey tmancey merged commit af0251a into main Oct 1, 2021
@tmancey tmancey deleted the can_fallback_on_windows_and_android branch October 1, 2021 14:29
tmancey added a commit that referenced this pull request Oct 16, 2021
@tmancey
Revert "Merge pull request #128 from brave/can_fallback_on_windows_an…
ad72286 
…d_android"

This reverts commit af0251a, reversing
changes made to a1f517c.
tmancey added a commit that referenced this pull request Oct 16, 2021
@tmancey
Revert "Merge pull request #128 from brave/can_fallback_on_windows_an…
9025e6a 
…d_android"

This reverts commit af0251a, reversing
changes made to a1f517c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

@moritzhaller moritzhaller Awaiting requested review from moritzhaller

@iefremov iefremov Awaiting requested review from iefremov

Assignees

@tmancey tmancey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @goodov