Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Checkbox gets keyboard accessibility #595

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Checkbox gets keyboard accessibility #595

merged 2 commits into from
Nov 1, 2021

Conversation

petemill
Copy link
Member

Changes

  • Adds testing-library dependencies and setup
  • Adds focus ability and style to checkbox (also hover to bring closer to design system)
  • Tests focusability
Link / storybook path to visual changes

image

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@petemill petemill self-assigned this Oct 29, 2021
@petemill petemill changed the title Setup testing-library for nicer dom tests Checkbox gets keyboard accessibility Oct 29, 2021
Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@petemill
Copy link
Member Author

petemill commented Nov 1, 2021

CI failure is existing npm audit issue

@petemill petemill merged commit e89ec52 into master Nov 1, 2021
@petemill petemill deleted the checkbox-focusable branch November 1, 2021 16:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants