Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same password field should be focused on tab after entering existing extension password #19030

Closed
srirambv opened this issue Oct 27, 2021 · 2 comments · Fixed by brave/brave-core#10882

Comments

@srirambv
Copy link
Contributor

Description

Use same password field should be focused on tab after entering existing extension password

Steps to Reproduce

  1. Install MM or CW
  2. Enable native wallet
  3. Detects existing wallets and prompts to import account
  4. Enter existing account password and press tab
  5. Selects new password instead of use same password checkbox

Actual result:

Selects new password instead of use same password checkbox when user presses tab after entering old password

Expected result:

Use same password field should be focused on tab after entering existing extension password

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.33.34 Chromium: 95.0.4638.54 (Official Build) nightly (x86_64)
Revision d31a821ec901f68d0d34ccdbaea45b4c86ce543e-refs/branch-heads/4638@{#871}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @Douglashdaniel

@Douglashdaniel
Copy link

Is going to require this update to brave-ui brave/brave-ui#595

@srirambv
Copy link
Contributor Author

srirambv commented Nov 9, 2021

Brave 1.32.95 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.282)
☑️ macOS Version 11.5.2
(Build 20G95)
  • Verified steps from issue description
  • Verified tab sets focus to checkbox for easier keyboard accessibility
Linux.mov
Windows.mov
macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants