Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Brave UI Allows Checkbox to be Focused #10917

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Upgrade Brave UI Allows Checkbox to be Focused #10917

merged 1 commit into from
Nov 8, 2021

Conversation

Douglashdaniel
Copy link
Contributor

@Douglashdaniel Douglashdaniel commented Nov 5, 2021 •
edited by kjozwiak
Loading

Uplift of #10882
Resolves brave/brave-browser#19030

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Douglashdaniel Douglashdaniel added this to the 1.32.x - Beta milestone Nov 5, 2021
@Douglashdaniel Douglashdaniel requested a review from a team November 5, 2021 20:25
@Douglashdaniel Douglashdaniel self-assigned this Nov 5, 2021
kjozwiak
kjozwiak approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.32.x approved 👍

@kjozwiak kjozwiak merged commit e4338b2 into 1.32.x Nov 8, 2021
@kjozwiak kjozwiak deleted the upgrade-brave-ui-checkbox-index-1.32.x branch November 8, 2021 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Douglashdaniel Douglashdaniel

Labels
None yet
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@Douglashdaniel @kjozwiak