Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Remove brave-core specific Welcome page feature #534

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

petemill
Copy link
Member

Changes

Removes Welcome from brave-ui since it has already been moved to brave-core via brave/brave-core#2896

Partially addresses brave/brave-browser#2335

Test plan

Storybook still works. Tests still work.

Link / storybook path to visual changes

Integration

Backwards compatible since brave-core no longer uses brave-ui for Welcome page!

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@petemill petemill self-assigned this Sep 10, 2019
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2019-10-03 at 11 41 21 AM

💯thanks Pete!

@cezaraugusto
Copy link
Contributor

btw once we clean up the feature components we should start thinking about where our feature themes will be hosted.

@cezaraugusto cezaraugusto merged commit d203620 into master Oct 3, 2019
@cezaraugusto cezaraugusto deleted the remove-welcome branch October 3, 2019 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants