Welcome Page: Move from brave-ui to brave-core #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
brave-ui-welcome
branch
2 times, most recently
from
2eac9fd
to
b42e1fe
Compare
imptrx
reviewed
Jul 15, 2019
|
I'm going to add the 'imported from' prefix as some of these commits don't mention the welcome page |
petemill
force-pushed
the
brave-ui-welcome
branch
2 times, most recently
from
277db49
to
b6b983b
Compare
petemill
previously approved these changes
Jul 17, 2019
There was a problem hiding this comment.
Works great. I needed to rebase on master to review, so I also added the prefix to the commit messages and fixed the spelling on another one.
I did add some nits regarding some import paths which unnecessarily traverse the FS. They are minor but stops the directory being fully self-contained. Will leave it up to you @cezaraugusto as if it's ever a problem it will be apparent and could easily be fixed at the time.
| @@ -13,7 +13,7 @@ import { | |||
| SkipButton, | |||
| FooterButton, | |||
| Bullet | |||
| } from 'brave-ui/features/welcome' | |||
| } from '../../../../components/brave_welcome_ui/components' | |||
There was a problem hiding this comment.
nit: exits UI folder then goes back in - can we replace ../../../../components/brave_welcome_ui with ../../?
|
|
||
| // Images | ||
| import { WelcomeRewardsImage } from 'brave-ui/features/welcome/images' | ||
| import { WelcomeRewardsImage } from '../../../../components/brave_welcome_ui/components/images' |
|
|
||
| // Images | ||
| import { WelcomeSearchImage } from 'brave-ui/features/welcome/images' | ||
| import { WelcomeSearchImage } from '../../../../components/brave_welcome_ui/components/images' |
|
|
||
| // Utils | ||
| import { getLocale } from '../../../common/locale' | ||
|
|
||
| // Images | ||
| import { WelcomeShieldsImage } from 'brave-ui/features/welcome/images' | ||
| import { WelcomeShieldsImage } from '../../../../components/brave_welcome_ui/components/images' |
|
|
||
| // Images | ||
| import { WelcomeThemeImage } from 'brave-ui/features/welcome/images' | ||
| import { WelcomeThemeImage } from '../../../../components/brave_welcome_ui/components/images' |
|
|
||
| // Shared components | ||
| import { ArrowRightIcon } from 'brave-ui/components/icons' | ||
|
|
||
| // Images | ||
| import { WelcomeLionImage } from 'brave-ui/features/welcome/images' | ||
| import { WelcomeLionImage } from '../../../../components/brave_welcome_ui/components/images' |
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| import { Dispatch } from 'redux' | |||
| import { getSearchEngineProvidersSuccess, getBrowserProfilesSuccess } from './actions/welcome_actions' | |||
| import { State as ImportBoxState } from '../brave_welcome_ui/components/screens/importBox' | |||
| import { State as ImportBoxState } from '../brave_welcome_ui/containers/screens/importBox' | |||
There was a problem hiding this comment.
nit: path exits UI and then goes back in - can just be ./
cezaraugusto
force-pushed
the
brave-ui-welcome
branch
from
b6b983b
to
f863a3e
Compare
|
good catch, thanks @petemill. updated |
cezaraugusto
force-pushed
the
brave-ui-welcome
branch
from
f863a3e
to
b64592b
Compare
…e` props to `customStyle`
… spec - this removes legacy theme file and other goodies
…e-specific compnents
-hover states on secondary button updates, this was actually to button component code and not theme but was intentional changes - started incorporating the brave palette when necessary - updated bg svg to fill more of the space - adjusted select component to brave palette and further from the purple aesthetic to a more netural form component
- small padding adjustments to button components, more left right space - added lettering spacing to button component. letters were running into eachother - updated all teh graphics to a more standard size and svg - vertically aligned the content in the panel. i don't think this inline css styling of the panel is the best way this should be done but it's the idea and i saw other css there - deleted pngs - adjusted bg svg color from bright orange to more of a rewards color - adjusted wording in some locale - the button component for a green "success" state on active might bea good addition to the button components. we have "warn" but no success alternative. -
- adjusted caps text to sentence case like our other standard buttons - adjusted the background svg back down to 600-ish pixels - adjusted the button icons to fall more in line with 4px scale increments
- updated to latest approved copy from Brad R. - adjusted one button accent - animation updates i had previously had staged and forgot to commit
- the text change of the button didn't make sense until we have a dropdown present so i changed both states to the same
-ease updates
- met in the middle for animation timing but a little on the faster side. these panels are big though and require some time to transition without feeling like it's jumping.
svg asset and text
…nding on region defaults
…ton into local state
…Card since it had overriden almost all properties
petemill
force-pushed
the
brave-ui-welcome
branch
from
40658bb
to
d95463f
Compare
petemill
approved these changes
Jul 24, 2019
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address brave/brave-browser#2335
close brave/brave-browser#5216
Test Plan