Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Fix New Tabs Page display for RTL Languages #469

Merged
merged 1 commit into from
May 17, 2019

Conversation

imptrx
Copy link
Contributor

@imptrx imptrx commented May 17, 2019

Changes

Test plan

For testing with brave-core

  • Launch brave while system locale is LTR (English), and RTL (Arabic, Hebrew)
  • Open new tabs page and widgets should not be flush with edge
  • Resize window to check for responsive behavior

For testing with storybook

  • Manually edit enclosing html for new tabs page feature with attribute dir="rtl"
Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)
  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@imptrx imptrx requested a review from cezaraugusto May 17, 2019 17:52
@imptrx imptrx changed the title Update NTP display for RTL locale displays Fix New Tabs Page display for RTL Languages May 17, 2019
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks Peter!

@cezaraugusto cezaraugusto merged commit 079dbad into master May 17, 2019
@cezaraugusto cezaraugusto deleted the fix-rtl-support-NTP branch May 17, 2019 18:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants