-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clock and stats padding for right-to-left languages on the New Tab Page #3574
Comments
here the photo! |
@levi128 What do you mean by asymmetrical? The font sizing of the clock (larger) versus the stats? |
It's a bit too much on the sides .. the clock and the stats! moment. I'll send pictures. In English it's fine. But in Hebrew it's a bit out of the middle! |
The first one is in Hebrew. The second English! See the differences? |
For Hebrew locale (probably effects Arabic too or rtl languages), need to add proper padding on right and left side for stats and clock. Both are flush to the window. |
@imptrx does this require manual QA? if so, can you add a test plan and |
@LaurenWags Here is the test plan! Steps to check:
Assert:
|
awesome, thanks @imptrx 😄 |
Verification passed on
Arabic: Hebrew: Verification passed on
Verified passed with
|
Description
the widgets are Asymmetrical when i'm using the Hebrew language!
Fix?
Steps to Reproduce
Actual result:
https://imgur.com/CljFIsI
https://imgur.com/ZPck5r6
Expected result:
Reproduces how often:
Brave version (brave://version info) 0.60.47 Chromium: 72.0.3626.119
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: