Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Adds reserved amount to wallet summary #340

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Adds reserved amount to wallet summary #340

merged 3 commits into from
Jan 9, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 7, 2019 •
edited
Loading

Changes

  • adds info about reserved funds in wallet summary
  • removes change setting button from the panel

Test plan

Link / storybook path to visual changes

Integration

  • Does this contain changes to src/components or src/

    • Will you publish to npm immediately after this PR, or wait until sometime in the future?
    • Incompatible API change to something existing (major version increase)
    • Adding new backwards-compatible functionality? (minor version increase)
    • Fixing a bug backwards-compatibly? (patch version increase)

  • Does this contain changes to src/features for brave-core?

    • Are there non backwards-compatible changes required for brave-core? Do not merge until brave-core PR is approvable. Link to brave-core PR:
    • Will you create brave-core PR to update to this commit after it is merged?
    • Wants uplift to brave-core feature branch?
      • When uplift-approved, merge to brave-core-0.VV.x feature branch
      • Create additional brave-core PRs for each feature branch to update commit

@NejcZdovc NejcZdovc self-assigned this Jan 7, 2019
@NejcZdovc NejcZdovc mentioned this pull request Jan 7, 2019
Merged
18 tasks
@NejcZdovc NejcZdovc requested review from ryanml and bsclifton January 9, 2019 08:05
@NejcZdovc NejcZdovc force-pushed the contribution-nonverified branch from 7e80cb6 to b63b022 Compare January 9, 2019 08:24
@NejcZdovc
Increase panel height
0388c48 
Fixes learn more spacing
@NejcZdovc NejcZdovc force-pushed the contribution-nonverified branch from b63b022 to 0388c48 Compare January 9, 2019 08:26
ryanml
ryanml approved these changes Jan 9, 2019
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@ryanml ryanml merged commit f31f023 into master Jan 9, 2019
@ryanml ryanml deleted the contribution-nonverified branch January 9, 2019 08:36
NejcZdovc pushed a commit that referenced this pull request Jan 9, 2019
@ryanml @NejcZdovc
Merge pull request #340 from brave/contribution-nonverified
2559426 
Adds reserved amount to wallet summary
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Jan 9, 2019 •
edited
Loading

master (0.61) f31f023
0.60 2559426
0.59 9c51b8d
0.58 816ffa8

NejcZdovc pushed a commit that referenced this pull request Jan 9, 2019
@ryanml @NejcZdovc
Merge pull request #340 from brave/contribution-nonverified
9c51b8d 
Adds reserved amount to wallet summary
NejcZdovc pushed a commit that referenced this pull request Jan 9, 2019
@ryanml @NejcZdovc
Merge pull request #340 from brave/contribution-nonverified
816ffa8 
Adds reserved amount to wallet summary
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanml ryanml ryanml approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@NejcZdovc NejcZdovc

Labels
rewards
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NejcZdovc @ryanml