Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new contribution flow for unverified publishers #1236

Merged
merged 12 commits into from
Jan 9, 2019
Merged

Adds new contribution flow for unverified publishers #1236

merged 12 commits into from
Jan 9, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 7, 2019 •
edited
Loading

Resolves brave/brave-browser#2836

UI implementation: brave/brave-ui#340

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Jan 7, 2019
@NejcZdovc NejcZdovc force-pushed the contribution-nonverified branch 5 times, most recently from 0abe7ad to 06401c7 Compare January 8, 2019 09:48
bridiver
bridiver reviewed Jan 8, 2019
View reviewed changes
components/brave_rewards/browser/rewards_service.h
@@ -57,6 +57,7 @@ using GetPublisherAllowVideosCallback = base::Callback<void(bool)>;
using GetAutoContributeCallback = base::Callback<void(bool)>;
using GetReconcileStampCallback = base::Callback<void(uint64_t)>;
using IsWalletCreatedCallback = base::Callback<void(bool)>;
using GetPendingContributionsTotalCallback = base::Callback<void(double)>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be base::CallbackOnce and update to use base::BindOnce. base::Callback and base::Bind are deprecated in favor of Once/Repeating

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi - you need to use std::move when passing or calling a base::CallbackOnce callback

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to add it, but it's failing for me, will contact you via DM

@NejcZdovc NejcZdovc force-pushed the contribution-nonverified branch from 06401c7 to 45be68a Compare January 8, 2019 21:31
@bsclifton
Copy link
Member

bsclifton commented Jan 8, 2019 •
edited
Loading

Realtime notes while testing:

  • @evq helped me find the list of verified sites for staging; tipping verified sites works as expected 👍
  • tipping non-verified sites correctly adds the side-banner text with the proper amount 👍
  • adding recurring donations for verified site works 👍
  • adding recurring for non-verified sites works 👍
  • using the -- --rewards=staging=true,reconcile-interval=2 syntax didn't work unfortunately. Did the options change? I wanted to test reconcile

bsclifton
bsclifton reviewed Jan 9, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment left, but otherwise looks good 😄 Also see @bridiver's feedback (which may be blocking). I can do a formal review if/when ready for final review

@NejcZdovc NejcZdovc force-pushed the contribution-nonverified branch from 0dd2419 to 11ac85e Compare January 9, 2019 08:07
@NejcZdovc NejcZdovc force-pushed the contribution-nonverified branch from 11ac85e to 960404c Compare January 9, 2019 09:32
@NejcZdovc NejcZdovc force-pushed the contribution-nonverified branch from 960404c to 985c461 Compare January 9, 2019 09:35
@NejcZdovc NejcZdovc merged commit 8ea4875 into master Jan 9, 2019
@NejcZdovc NejcZdovc deleted the contribution-nonverified branch January 9, 2019 15:58
NejcZdovc added a commit that referenced this pull request Jan 9, 2019
@NejcZdovc
Merge pull request #1236 from brave/contribution-nonverified
495e561 
Adds new contribution flow for unverified publishers
@NejcZdovc NejcZdovc mentioned this pull request Jan 9, 2019
Merged
NejcZdovc added a commit that referenced this pull request Jan 9, 2019
@NejcZdovc
Merge pull request #1236 from brave/contribution-nonverified
697cab2 
Adds new contribution flow for unverified publishers
@NejcZdovc NejcZdovc mentioned this pull request Jan 9, 2019
Merged
NejcZdovc added a commit that referenced this pull request Jan 9, 2019
@NejcZdovc
Merge pull request #1236 from brave/contribution-nonverified
90eab95 
Adds new contribution flow for unverified publishers
@NejcZdovc NejcZdovc mentioned this pull request Jan 9, 2019
Merged
@bbondy bbondy added this to the 0.61.x - Nightly milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@yrliou yrliou Awaiting requested review from yrliou

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
0.61.x - Release
Development

Successfully merging this pull request may close these issues.

Implement new contribution flow for unverified publishers
5 participants
@NejcZdovc @bsclifton @bridiver @yrliou @bbondy