Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Combines disabled text strings #227

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Combines disabled text strings #227

merged 1 commit into from
Oct 23, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 23, 2018

Fixes #226

Related to brave/brave-browser#1723

@ryanml ryanml self-assigned this Oct 23, 2018
NejcZdovc
NejcZdovc previously requested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep everything as is and just remove br. This way translations doesn't need to change.

@ryanml ryanml requested a review from NejcZdovc October 23, 2018 05:34
@NejcZdovc NejcZdovc merged commit 90cff53 into brave:master Oct 23, 2018
@NejcZdovc NejcZdovc mentioned this pull request Oct 24, 2018
Merged
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@petemill petemill Awaiting requested review from petemill

@cezaraugusto cezaraugusto Awaiting requested review from cezaraugusto

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanml @NejcZdovc