Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds captcha error flow #721

Merged
merged 3 commits into from
Oct 24, 2018
Merged

Adds captcha error flow #721

merged 3 commits into from
Oct 24, 2018

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Oct 24, 2018

Resolves brave/brave-browser#1723
Resolves brave/brave-browser#1556
Resolves brave/brave-browser#1502
Resolves brave/brave-browser#1794

Ledger implementation: brave-intl/bat-native-ledger#156
UI implementation: brave/brave-ui#233
UI implementation: brave/brave-ui#231
UI implementation: brave/brave-ui#229
UI implementation: brave/brave-ui#227

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  • clean profile
  • enable rewards via panel
  • make sure that you see spinner (we will fix missing translation with translation update)
  • go to rewards page
  • turn rewards off
  • make sure that first paragraph at the end is not split
  • resize window and make sure that min width is 1024px
  • click claim grant
  • turn internet off
  • dnd logo
  • make sure that you see ups message

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@NejcZdovc NejcZdovc self-assigned this Oct 24, 2018
@NejcZdovc NejcZdovc force-pushed the captcha-error branch 4 times, most recently from ac3a1f4 to 04fee11 Compare October 24, 2018 08:07
@NejcZdovc NejcZdovc force-pushed the captcha-error branch 2 times, most recently from 00b8f7f to d052b35 Compare October 24, 2018 14:40
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@NejcZdovc NejcZdovc merged commit 782487d into master Oct 24, 2018
@NejcZdovc NejcZdovc deleted the captcha-error branch October 24, 2018 17:16
NejcZdovc added a commit that referenced this pull request Oct 24, 2018
NejcZdovc added a commit that referenced this pull request Oct 24, 2018
NejcZdovc added a commit that referenced this pull request Oct 24, 2018
@NejcZdovc
Copy link
Contributor Author

master 782487d
0.57.x 70a8380
0.56.x 1c858e2
0.55.x 1014766

@bbondy
Copy link
Member

bbondy commented Oct 30, 2018

Updated label to 0.56.x since this won't appear in 0.55.x hotfix2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment